veb, vweb: update unit tests for FreeBSD #25972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spytheman
approved these changes
Dec 15, 2025
Member
There was a problem hiding this comment.
Thank you for investigating, and keeping these tests pass on the latest FreeBSD (even if skipped).
What do you think of the idea, of detecting it also at startup, in the implementation code for vweb and veb, and then showing a message about it (searching for params.show_startup_message can show where)?
Contributor
Author
|
Adding a message at startup time sounds like a good idea. I'll look at it if you like. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update unit tests to deal with net.inet.ip.connect_inaddr_wild on FreeBSD
This is a potential fix for issue 25935.
It checks for the existence of the net.inet.ip.connect_inaddr_wild sysctl and if it exists and if it is zero, it skips checking for the IPv6 socket listening for connections.
Prior to FreeBSD 14, there was no sysctl named net.inet.ip.connect_inaddr_wild and opening a socket on localhost would open both an IPv4 and IPv6 socket. In FreeBSD 14, this sysctl was introduced with a default value or 1. This retained the behavior of FreeBSD 13 and earlier. With the release of FreeBSD 15, this value now defaults to 0 which means that opening a socket on localhost only opens the IPv4 socket. There are more details in the related issue.