msvc: split multi-token -I/-L values from pkg-config#26637
Merged
medvednikov merged 2 commits intovlang:masterfrom Feb 21, 2026
Merged
msvc: split multi-token -I/-L values from pkg-config#26637medvednikov merged 2 commits intovlang:masterfrom
medvednikov merged 2 commits intovlang:masterfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4f29ee1a0e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix MSVC handling of pkg-config output where
-I/-Lvalues contain multiple tokens(e.g.
-Ifoo -Ibar -Lbaz) by splitting and applying them individually.What was wrong
pkg-config sometimes returns multiple
-I/-Ltokens inside a single flag value.The MSVC builder previously wrapped the entire value into one
/I"..."or/LIBPATH:"..."argument, so embedded
-I/-Ltokens were passed verbatim inside the string.MSVC ignored/misparsed those, causing missing include paths (e.g.
glibconfig.h).What changed
The
-Iand-Lbranches now split multi-token values and apply each part separately.This prevents embedded GNU-style tokens from being smuggled inside a single MSVC argument.
Repro
Build a GUI example on Windows with MSVC and vcpkg glib/pango installed; previously
glibconfig.hwas missing even though include paths were present.Tests
Not run (local build of
arrows.vsucceeded).Changed files