sqlite: use bundled amalgamation on Linux/macOS when pkg-config is unavailable#26817
Merged
JalonSolov merged 1 commit intoApr 10, 2026
Conversation
Contributor
Author
|
All the failures are unrelated to this change. The common failure across all Linux CI jobs is: This is a pre-existing bug in the native backend ( The mssql and mysql failures are also unrelated — the mssql log shows the SQL Server container initializing (a timeout/infrastructure issue). The docker-alpine-musl jobs are likely also the same native backend issue. This change is clean — the failures are pre-existing on master. |
…available When `pkg-config sqlite3` fails, fall back to compiling the bundled `thirdparty/sqlite/sqlite3.c` directly instead of `-lsqlite3`, which requires a system development package. Users can obtain the amalgamation by running `vlib/db/sqlite/install_thirdparty_sqlite.vsh`. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1e82558 to
55674f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pkg-config sqlite3fails on Linux/macOS, the module previously fell back to-lsqlite3, which requires a system development package to be installed#flag @VEXEROOT/thirdparty/sqlite/sqlite3.c, compiling the bundled amalgamation directly — consistent with what already works on Windowsvlib/db/sqlite/install_thirdparty_sqlite.vshto obtain the amalgamationTest plan
vlib/db/sqlite/install_thirdparty_sqlite.vshon a Linux system withoutlibsqlite3-devinstalledv run vlib/db/sqlite/sqlite_test.vpassesFixes #26830