super_batch7#26932
Conversation
(cherry picked from commit a3ba0ee041bbd13dfeb7f3d7e48102f51f16f519)
(cherry picked from commit ec69e8d7533fc88489361f7edd8897c9d5a9ca77)
(cherry picked from commit 3f216984d7720d74b30ca2df78bc750bd3353c07)
(cherry picked from commit 9c64e2ab7034594b5c789b8809375e3e6f808a08)
… empty maps (fixes #26908) (cherry picked from commit bbf351602bdc33bf58753ec9caf9a617c3d83eb5)
…6910) (cherry picked from commit 5f1265691c943e9c932285be758f56ebcb5d0925)
(cherry picked from commit 1df46dd3e6e69d8d454a4d245bd86e0d49381d20)
…rator (fixes #26913) (cherry picked from commit 4058395910204a2c89b7538e9470bc0ef7490b85)
…#26915) (cherry picked from commit 0d30244b3584d04f07eb8c4dccd027f0bc409927)
(cherry picked from commit 270a916f604e987d445d6b8b4f6482a55ecc052f)
(cherry picked from commit b649f207869e408b53793e72dde0bc02e2f60eef)
(cherry picked from commit bbb0a971b21fb2a54dff719d05ef0ec01b2e9499)
…16512) (cherry picked from commit 9ebb81d4dc74f736716622237f960c5ac24dace6)
fixes #16635) (cherry picked from commit b5783154ed7c6e32d9645962aed2e436c574480b)
(cherry picked from commit 6cb1e4b212546b06e62894ec60a8b5d95a9dffe4)
(cherry picked from commit ae01373de871a432f46a094ace204929eb109722)
(cherry picked from commit 1878e002e5060af55785371eaa086937eadf7c27)
#26527) (cherry picked from commit c25c0233c8baf62be411538e3d24fa4b6137a48e)
(cherry picked from commit 6e224d2f042a84e2be62850d61c5d451d88e0607)
…12445) (cherry picked from commit 195ea74de3b5da85a54dfb50a83cedad3064d9c4)
#14160) (cherry picked from commit d74b651037403cd96182490c2cd0329e48c750d2)
(cherry picked from commit 0ae21b74b9daf4cd2433c4cb2fab30fc966a538f)
…out noinit (fixes #18427) (cherry picked from commit 6aa6e451cea5eecaebf1172f7aa0a7dfbff95551)
…fixes #19010) (cherry picked from commit ab0ce0e9bfd4d59e56cd0b838d3cfa2afbc0d25f)
#20744) (cherry picked from commit 02415f64deb3ca2b6100bafbb16e6f4daf3ab8c9)
#25248) (cherry picked from commit e2f36d435f9fbf322a5150ede50b3c7dff5c9d25)
(cherry picked from commit 680fae89bff671bda352ec62464e24764b98932f)
(cherry picked from commit 72a4371b5005a57c671d1e018436fffe06d69cd9)
(cherry picked from commit cbd2b06a5ff11d5e5284e6d4e5856e6ee3664e60)
…#17850) (cherry picked from commit 87d861030d5a96e17c2667abc2e5bc9111b51645)
#26164) (cherry picked from commit c7cd97c67e5102b2e23cf66375ed2d2e71cdffbd)
…22237) (cherry picked from commit 10f0210d1cbfbc0b921425e39282d5e86879fb92)
…ixes #19456) (cherry picked from commit cfc90e6c46c9f721f49f732356f900509143d72f)
…used for casting (fixes #26192) (cherry picked from commit 3d2f7e071cab89af7be512c28dd4e7943c5c6cfc)
…2886) (cherry picked from commit cc34b6ae099101f16d7c92ec8932d321dc96f6ee)
…ing (fixes #26928) (cherry picked from commit 422c5119c0bcd8963ad048fb3d385faa9752abe9)
(cherry picked from commit 83df68669b90836fb7009bb21d0f958dba2e4853)
(cherry picked from commit efd6011a79c342436ad6f4808ddd23215d50a15c)
…26815) (cherry picked from commit ab9d05761229fddb7c9b28abf71167e4eff2dbff)
…ranch (fixes #26893) (cherry picked from commit 918e019d075c03a47becc5d70cbb019e2336e5e1)
(cherry picked from commit 62437b95f9d7668125d1f1a4522c43f24cc8aea0)
…6905) (cherry picked from commit 525c3a34bae140b5c22e30a85071f3a6ec40be5b)
…]t (fixes #26899) (cherry picked from commit 644e73a4096dbd189a295e38f4a8f94e336962f1)
(cherry picked from commit 063c1ce9241b899b6d832db54902472b320900b7)
…ixes #3054) (cherry picked from commit aea94cd2ec089af4991bca8660237869ad143102)
#19466) (cherry picked from commit fc5a1bf9ce1b545e05d5c1c79746a3c8eba1108f)
(cherry picked from commit 3b6143740314f22a6d7662cc45727a7d33a08a3c)
(cherry picked from commit e592c6ac5f299a255811cc63df0429b1fd0bf49c)
…def (fixes #18918) (cherry picked from commit 07ffb4a5333b3d717010a17a1474b787dee1d49f)
(cherry picked from commit ca2bc2023ed24b418cfa4cec09e8c4e40806e8df)
(cherry picked from commit dd594699e23de07e08318828d7d7ff1347d6560a)
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6d5e368a6a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| process.wait() | ||
| stdout_output := process.stdout_slurp() | ||
| stderr_output := process.stderr_slurp() |
There was a problem hiding this comment.
On Windows this helper calls process.wait() before reading redirected stdout/stderr, which can deadlock when the child emits enough output to fill the pipe buffers (the process API uses fixed-size pipes). In that case the child blocks on write, never exits, and the REPL hangs indefinitely for verbose compiler/runtime output. Read/drain output while the process is running (or switch back to os.execute-style capture) before waiting.
Useful? React with 👍 / 👎.
| session.protocol_version = if params.protocol_version == s.protocol_version { | ||
| s.protocol_version | ||
| } else { | ||
| s.protocol_version |
There was a problem hiding this comment.
This initialization branch accepts any client protocolVersion because both sides of the conditional assign the same server version, so mismatched protocol versions are silently treated as successful initialization. That can produce hard-to-diagnose behavior later when client/server semantics diverge; the initialize path should explicitly reject unsupported versions (or perform real negotiation) instead of always succeeding.
Useful? React with 👍 / 👎.
|
@codex review |
medvednikov
force-pushed
the
super_batch7
branch
from
6d5e368 to
d39b5ff
Compare
medvednikov
force-pushed
the
super_batch7
branch
from
921cab5 to
c7c0e9e
Compare
|
Already on master |
1 participant
Summary
Batch of 135 upstream bug fixes cherry-picked from individual
batchX-issue-XXXbranches, plus a finalall: super_batch7 fixescommit squashing compiler-visibility fixes needed to self-compile.Prefixed, deduplicated commit titles (
checker:,cgen:,builder:,x.json2:, …). Largest groups:checker:24,cgen:24,builder:14.Test plan
./v selfsucceeds and runs at master-level speedv test-selfpasses./v -o /tmp/vtest cmd/tools/vdoctor.vbuilds🤖 Generated with Claude Code