Fix docker compose and Grafana observability#6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This merge request fixes Docker Compose startup issues and improves Grafana observability accuracy by:
migrate-indexescontainer startup failure.Scope of Changes
Changed files:
Dockerfileapp/observability/setup.pyobservability/grafana/dashboards/commerce-observability.jsonobservability/grafana/dashboards/commerce-observability-p2.jsonobservability/grafana/dashboards/commerce-observability-p3.jsonobservability/grafana/provisioning/datasources/datasources.ymlDiff summary:
6 files changed202 insertions,1 deletionWhat Was Fixed
1. Docker Compose startup failure (
migrate-indexes)scripts/migrate_indexes.pywas not present in the runtime image.COPY scripts/ ./scripts/inDockerfile.docker compose up -d --buildnow completes withmigrate-indexessucceeding.2. Missing histogram context for p95 panels
3. Grafana alerting error with Loki datasource
Unable to fetch alert rules ... Is the Loki data source properly configured?manageAlerts: falsefor Loki datasource indatasources.yml.4. Unit consistency for latency panels
fieldConfig.defaults.unit: "ms"to all(ms)p95 panels.5. Histogram quantile precision issue
Views inapp/observability/setup.py.commerce_http_request_duration_secondscommerce_http_response_time_secondscommerce_http_processing_duration_secondscommerce_http_queue_wait_duration_secondscommerce_db_query_duration_secondsValidation Performed
docker compose buildcompleted successfully.docker compose up -d --buildsucceeded after Dockerfile fix.docker compose psconfirmed expected services up.docker compose logs migrate-indexesconfirmed successful migration execution.jq empty./metricsverified to expose new explicit histogram bucket boundaries (0.005,0.01,0.025, ...).Notes for Reviewers
[5m]) to fully reflect new bucket behavior after deployment.