[Refactor Followup] Fix data package type and quality errors #430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jared O'Connell <joconnel@redhat.com>
Signed-off-by: Jared O'Connell <joconnel@redhat.com>
Signed-off-by: Jared O'Connell <joconnel@redhat.com>
Signed-off-by: Jared O'Connell <joconnel@redhat.com>
jaredoconnell
force-pushed
the
features/refactor/type-fixes-5
branch
from
7564645 to
ad41a66
Compare
sjmonson
requested changes
Oct 21, 2025
Signed-off-by: Jared O'Connell <joconnel@redhat.com>
sjmonson
previously approved these changes
Oct 21, 2025
markurtz
requested changes
Oct 22, 2025
| break # Found one that works. Continuing could overwrite it. | ||
|
|
||
| if dataset is None and len(errors) > 0: | ||
| raise DataNotSupportedError( |
There was a problem hiding this comment.
This error message can get a bit unruly here, can we distinguish between not supported errors and dataset errors?
| ) + num_chars | ||
| if (num_words := stats.get("num_words")) is not None: | ||
| input_metrics.text_words = (input_metrics.text_words or 0) + num_words | ||
| input_metrics.text_characters = ( |
There was a problem hiding this comment.
I would like to keep the counting logic unified in the text_stats function. We could update it so that it pushes to a UsageMetrics instance directly / make that a functoin of the UsageMetrics class, but this code is duplicated and if we add anymore stats, it will make it hard to keep updated
There was a problem hiding this comment.
Fixed. I think the new code is a much more elegant solution.
Signed-off-by: Jared O'Connell <joconnel@redhat.com>
Signed-off-by: Jared O'Connell <joconnel@redhat.com>
markurtz
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes type and quality errors in the data package.
This brings the total type error count down to 124.
Some assumptions had to be made, so it would be a good idea to look for accidental changes in logic during your reviews.
Testing
Run benchmarks with various data input types to ensure they all work.
Use of AI
## WRITTEN BY AI ##)