[Refactor Followup] Fix type errors in scheduler package #436
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and Details
This PR fixed type errors in the scheduler package. Many of them are Null errors and some are fixing type annotations on more complex types. One group of errors is switching the type annotations to reflect that the data structures are only storing string IDs instead of the type instances.
There is one remaining type error that can be found by running
mypyon the scheduler folder. I believe that has to do with re-using the typing from the worker group in the singular worker. The problem is thatSchedulerStateis present in the group, but not the singular worker.This PR removes 44 type errors, bringing the current count to 83.
Test Plan
I ran some basic benchmarks.
Run benchmarks to ensure the scheduler is still working as intended.
Use of AI
## WRITTEN BY AI ##)