Skip to content

Support dashed arguments for benchmark args #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 31, 2025
Merged

Support dashed arguments for benchmark args #441

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a9f98f3
Support dashed arguments for benchmark args
sjmonson Oct 30, 2025
6d69079
Fix commandline arguments not overriding scenario if set to default
sjmonson Oct 31, 2025
84538d9
Change request_type precedence
sjmonson Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions src/guidellm/benchmark/schemas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@

import yaml
from pydantic import (
AliasChoices,
AliasGenerator,
ConfigDict,
Field,
ValidationError,
Expand Down Expand Up @@ -1796,9 +1798,8 @@ def create(
scenario_data = scenario_data["args"]
constructor_kwargs.update(scenario_data)

for key, value in kwargs.items():
if value != cls.get_default(key):
constructor_kwargs[key] = value
# Apply overrides from kwargs
constructor_kwargs.update(kwargs)

return cls.model_validate(constructor_kwargs)

Expand Down Expand Up @@ -1832,6 +1833,14 @@ def get_default(cls: type[BenchmarkGenerativeTextArgs], field: str) -> Any:
use_enum_values=True,
from_attributes=True,
arbitrary_types_allowed=True,
validate_by_alias=True,
validate_by_name=True,
alias_generator=AliasGenerator(
# Support field names with hyphens
validation_alias=lambda field_name: AliasChoices(
field_name, field_name.replace("_", "-")
),
),
)

# Required
Expand Down Expand Up @@ -1878,6 +1887,12 @@ def get_default(cls: type[BenchmarkGenerativeTextArgs], field: str) -> Any:
data_request_formatter: DatasetPreprocessor | dict[str, str] | str = Field(
default="chat_completions",
description="Request formatting preprocessor or template name",
validation_alias=AliasChoices(
"data_request_formatter",
"data-request-formatter",
"request_type",
"request-type",
),
)
data_collator: Callable | Literal["generative"] | None = Field(
default="generative", description="Data collator for batch processing"
Expand Down
Loading