fix(tests): add CI failure tolerance and fix 4 embedding tests (Section 5/5) #623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vllm-semantic-router ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
👥 vLLM Semantic Team NotificationThe following members have been identified for the changed files in this PR and have been automatically assigned: 📁
|
yehudit1987
force-pushed
the
fix_skipped_tests_5
branch
2 times, most recently
from
cb26fa5 to
5cc12a3
Compare
yehudit1987
force-pushed
the
fix_skipped_tests_5
branch
2 times, most recently
from
a925516 to
ba72fb3
Compare
yehudit1987
force-pushed
the
fix_skipped_tests_5
branch
from
ba72fb3 to
fdf4b91
Compare
yehudit1987
force-pushed
the
fix_skipped_tests_5
branch
2 times, most recently
from
ae7829d to
1f5c6f9
Compare
yehudit1987
force-pushed
the
fix_skipped_tests_5
branch
2 times, most recently
from
beb4c7c to
e634bc6
Compare
yehudit1987
force-pushed
the
fix_skipped_tests_5
branch
from
e634bc6 to
f19a1ab
Compare
Signed-off-by: Yehudit Kerido <ykerido@ykerido-thinkpadp1gen7.raanaii.csb>
yehudit1987
force-pushed
the
fix_skipped_tests_5
branch
from
f19a1ab to
b9af3bc
Compare
rootfs
reviewed
Dec 7, 2025
| run: | | ||
| make build-e2e | ||
| - name: Free up disk space |
Collaborator
There was a problem hiding this comment.
this is a good start, i think the /mnt directory can be used if possible (e.g. move models and symlink there)
rootfs
reviewed
Dec 7, 2025
| model_type | ||
| }; | ||
|
|
||
| // Validate model availability and fall back if necessary |
Collaborator
There was a problem hiding this comment.
maynot be the best option to fallback to different model. Would you mind disabling Gemma test and model download in CI?
Collaborator
|
merging it to unblock other PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable Gemma embedding model in CI tests since it's a gated model
requiring HF_TOKEN. Tests now use Qwen3-Embedding-0.6B exclusively.
This approach was discussed and approved by maintainers who decided
to focus on Qwen3 (non-gated) for CI tests.
See: https://github.com/vllm-project/semantic-router/issues/573#issuecomment-3607352121
Changes in candle-binding/semantic-router_test.go:
Changes in tools/make/models.mk:
Qwen3-Embedding-0.6B is fully open (no gating) and supports
Matryoshka dimension truncation (768/512/256/128) from its
native 1024 dimensions.
Resolves #573 (Section 5: Embedding Model Tests)