fix(helm): remove namespace template to resolve installation conflicts #651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The namespace.yaml template with lookup function causes installation failures when the namespace already exists. Removing this template allows Helm's --create-namespace flag to handle namespace creation properly, avoiding conflicts with existing namespaces. Fixes the error: namespaces "vllm-semantic-router-system" already exists Signed-off-by: bitliu <bitliu@tencent.com>
✅ Deploy Preview for vllm-semantic-router ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Remove Namespace from required resources check since namespace.yaml template has been removed. The namespace is now managed by Helm's --create-namespace flag instead of being part of the chart templates. Signed-off-by: bitliu <bitliu@tencent.com>
👥 vLLM Semantic Team NotificationThe following members have been identified for the changed files in this PR and have been automatically assigned: 📁
|
Remove namespace.yaml from required files list and Namespace from required resources check in the validation script. The namespace is now managed by Helm's --create-namespace flag. Signed-off-by: bitliu <bitliu@tencent.com>
Member
Author
|
done @yuluo-yx thanks |
szedan-rh
pushed a commit
to szedan-rh/semantic-router
that referenced
this pull request
Nov 19, 2025
vllm-project#651) * fix(helm): remove namespace template to resolve installation conflicts The namespace.yaml template with lookup function causes installation failures when the namespace already exists. Removing this template allows Helm's --create-namespace flag to handle namespace creation properly, avoiding conflicts with existing namespaces. Fixes the error: namespaces "vllm-semantic-router-system" already exists Signed-off-by: bitliu <bitliu@tencent.com> * fix(ci): update helm-ci workflow to remove namespace check Remove Namespace from required resources check since namespace.yaml template has been removed. The namespace is now managed by Helm's --create-namespace flag instead of being part of the chart templates. Signed-off-by: bitliu <bitliu@tencent.com> * fix(ci): update validate-chart.sh to remove namespace checks Remove namespace.yaml from required files list and Namespace from required resources check in the validation script. The namespace is now managed by Helm's --create-namespace flag. Signed-off-by: bitliu <bitliu@tencent.com> --------- Signed-off-by: bitliu <bitliu@tencent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix - This PR fixes a Helm chart installation issue related to namespace creation.
What this PR does / why we need it:
This PR removes the
namespace.yamltemplate from the Helm chart to resolve installation conflicts when the namespace already exists.Problem:
namespace.yamltemplate uses thelookupfunction to check if a namespace existsnamespaces "vllm-semantic-router-system" already existslookupfunction doesn't work reliably in all scenarios (OCI registries, certain Helm versions)Solution:
namespace.yamltemplate entirely--create-namespaceflag handle namespace creationTesting:
After this change, users can install the chart using:
The installation will work whether the namespace exists or not.
Pull Request opened by Augment Code with guidance from the PR author