Skip to content

fix(helm): remove namespace template to resolve installation conflicts #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 14, 2025
Merged

fix(helm): remove namespace template to resolve installation conflicts #651

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9eabdee
fix(helm): remove namespace template to resolve installation conflicts
Xunzhuo Nov 14, 2025
64efe0f
fix(ci): update helm-ci workflow to remove namespace check
Xunzhuo Nov 14, 2025
8aca920
fix(ci): update validate-chart.sh to remove namespace checks
Xunzhuo Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/helm-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,6 @@ jobs:
run: |
echo "::group::Verify Required Resources"
required_resources=(
"Namespace"
"ServiceAccount"
"PersistentVolumeClaim"
"ConfigMap"
Expand All @@ -128,6 +127,7 @@ jobs:
fi
done
echo "All required resources found"
echo "Note: Namespace is managed by Helm's --create-namespace flag"
echo "::endgroup::"

- name: Upload templates as artifacts
Expand Down
8 changes: 0 additions & 8 deletions deploy/helm/semantic-router/templates/namespace.yaml
View file
Open in desktop

This file was deleted.

3 changes: 1 addition & 2 deletions deploy/helm/validate-chart.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,6 @@ required_files=(
"templates/deployment.yaml"
"templates/service.yaml"
"templates/configmap.yaml"
"templates/namespace.yaml"
"templates/pvc.yaml"
"templates/serviceaccount.yaml"
"templates/ingress.yaml"
Expand All @@ -146,7 +145,6 @@ echo ""
# Test 7: Validate generated resources
log_info "Validating generated Kubernetes resources..."
resource_types=(
"Namespace"
"ServiceAccount"
"PersistentVolumeClaim"
"ConfigMap"
Expand All @@ -162,6 +160,7 @@ for resource in "${resource_types[@]}"; do
exit 1
fi
done
log_info "Note: Namespace is managed by Helm's --create-namespace flag"
echo ""

# Test 8: Validate Chart.yaml
Expand Down
Loading