Skip to content

Conversation

@Lumosis
Copy link
Collaborator

@Lumosis Lumosis commented Oct 28, 2025

Description

Add more coverage to precompilation and fix unit tests

Tests

Please describe how you tested this change, and include any instructions and/or
commands to reproduce.

Checklist

Before submitting this PR, please make sure:

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have made or will make corresponding changes to any relevant documentation.

@Lumosis Lumosis requested a review from jrplatin October 28, 2025 05:50
@github-actions
Copy link

Description

Start with a short description of what the PR does and how this is a change from
the past.

The rest of the description includes relevant details and context, examples:

  • why is this change being made,
  • the problem being solved and any relevant context,
  • why this is a good solution,
  • some information about the specific implementation,
  • shortcomings of the solution and possible future improvements.

If the change fixes a bug or a Github issue, please include a link, e.g.,:
FIXES: b/123456
FIXES: #123456

Tests

Please describe how you tested this change, and include any instructions and/or
commands to reproduce.

Checklist

Before submitting this PR, please make sure:

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have made or will make corresponding changes to any relevant documentation.

@Lumosis Lumosis force-pushed the lihao/avoid branch 3 times, most recently from e633e45 to b20afea Compare October 28, 2025 21:24
Signed-off-by: Lihao Ran <imlihao.ran@gmail.com>
@Lumosis Lumosis merged commit 841c5df into main Oct 29, 2025
3 checks passed
sierraisland pushed a commit that referenced this pull request Nov 7, 2025
Signed-off-by: Lihao Ran <imlihao.ran@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants