[0.11.0]Chery pick pta upgrade change #3940
Conversation
We notice that sometimes user build vllm-ascend with incorrect torch version. In this case, the build is passed, but when running the code, the error `AttributeError: '_OpNamespace' '_C_ascend' object has no attribute 'weak_ref_tensor'` is raised. Let's force the torch version to 2.7.1 and check the torch version when build from source to fix the issue. closes: vllm-project#3342 - vLLM version: v0.11.0rc3 - vLLM main: vllm-project/vllm@c9461e0 Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
Upgrade torch-npu to the official release version 2.7.1 - vLLM version: v0.11.0 - vLLM main: vllm-project/vllm@83f478b --------- Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
github-actions
bot
added
documentation
wangxiyuan
added
ready
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request pins the torch and torch-npu dependencies to version 2.7.1. This is reflected in the build files, requirement files, and documentation. As a result of this version pinning, a significant amount of conditional logic and version checks (version_check()) have been removed from the codebase, leading to a good simplification. The tests have also been updated accordingly.
However, I've found a critical issue in requirements.txt where the --extra-index-url needed to locate the torch-npu package has been commented out. This will likely break the installation process for users.
This PR cherry-pick two commit from main to upgrade torch-npu to 2.7.1 official release --------- Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
This PR cherry-pick two commit from main to upgrade torch-npu to 2.7.1 official release --------- Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
1 participant
This PR cherry-pick two commit from main to upgrade torch-npu to 2.7.1 official release