[Bugfix] support local dataset path in benchmark_serving

[wubai]

error message:

ValueError: Unsupported dataset path: /opt/dataset/LLaVA-OneVision-Data. Huggingface dataset only supports dataset_path from one of following: {'lmarena-ai/VisionArena-Chat', 'lmms-lab/LLaVA-OneVision-Data', 'AI-MO/aimo-validation-aime', 'Aeala/ShareGPT_Vicuna_unfiltered', 'AI-MO/NuminaMath-1.5', 'AI-MO/NuminaMath-CoT', 'lmarena-ai/vision-arena-bench-v0.1', 'likaixin/InstructCoder'}. Please consider contributing if you would like to add support for additional dataset formats.

Benchmark serving could not use local dataset path. So, check if dataset_path is available only depend on basename.

[github-actions]

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

[russellb]

Can you add the Signed-off-by header to your commit messages so the DCO check will pass in CI? Thanks!

[wubai]

Can you add the Signed-off-by header to your commit messages so the DCO check will pass in CI? Thanks!

Done.

[russellb]

This seems to change the behavior - not sure if it's correct?

>>> import os
>>> os.path.basename("lmms-lab/LLaVA-OneVision-Data")
'LLaVA-OneVision-Data'

Previously, the full string lmms-lab/LLaVA-OneVision-Data would be accepted, but now it would not.

[wubai]

lmms-lab/LLaVA-OneVision-Data would be accepted, because:

dataset_name = os.path.basename("lmms-lab/LLaVA-OneVision-Data")
dasaset_name would be 'LLaVA-OneVision-Data'
then

supported_datasets = {
            os.path.basename(path)
            for path in {'lmms-lab/LLaVA-OneVision-Data', 'Aeala/ShareGPT_Vicuna_unfiltered'}
        }

supported_datasets would be {'LLaVA-OneVision-Data', 'ShareGPT_Vicuna_unfiltered'}
so,
dasaset_name in supported_datasets
return True

[russellb]

ah, I see.

but that also means that asdfadsfasdfa/LLaVA-OpenVision-Data would be considered valid?

[wubai]

yes.
Or I can check two conditions, one for hugging face name like lmms-lab/LLaVA-OneVision-Data, another for complete local path like /opt/dataset/LLaVA-OneVision-Data'.

asdfadsfasdfa/LLaVA-OpenVision-Data is not valid, /asdfadsfasdfa/LLaVA-OpenVision-Data is valid and lmms-lab/LLaVA-OneVision-Data is valid.

[mergify]

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @wubai.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

[knlnguyen1802]

@wubai @russellb May I know why this PR close without merge, I am looking for this too.

[herotai214]

@wubai @russellb yes exactly; supporting local dataset path would definitely be a very helpful feature!