Update compatible packaging version #19279
Conversation
This will remove below error Setuptools>=77.0.0 requires "packaging>=24.2" to work properly. rocm-build.txt has correct but rocm.txt is missing
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @pramenku, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
Hello team, Gemini here, providing a summary of this pull request. This PR, authored by pramenku, aims to resolve a dependency error encountered when using Setuptools>=77.0.0. The error message indicates that Setuptools requires packaging>=24.2 to function correctly. The PR addresses this by adding the necessary packaging dependency with the required version constraint to the requirements/rocm.txt file, which was previously missing it according to the PR description.
Highlights
- Dependency Fix: Adds the
packaging>=24.2dependency torequirements/rocm.txtto satisfy the requirement ofSetuptools>=77.0.0and resolve a related error. - Requirements Update: Modifies the
requirements/rocm.txtfile to include the missingpackagingdependency.
Changelog
- requirements/rocm.txt
- Added the
packaging>=24.2dependency. - Adjusted the position of
setuptools-scm>=8due to the insertion of the new dependency.
- Added the
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request correctly addresses the dependency issue with setuptools requiring a newer version of packaging by adding the necessary packaging>=24.2 requirement to requirements/rocm.txt. This aligns with the fix mentioned in the pull request description.
Summary of Findings
- Dependency Update: The pull request successfully updates the
packagingdependency inrequirements/rocm.txtto resolve a compatibility issue withsetuptools. No issues meeting the specified severity levels (medium,high,critical) were found in the changes.
Merge Readiness
The code changes appear correct and directly address the reported dependency issue. Assuming that CI checks (which would build and test with these requirements) pass, this pull request seems ready to be merged. As a reviewer, I am unable to directly approve the pull request; please ensure other reviewers have approved before merging.
&& pip install setuptools_scm is redundant
|
@gshtras @DarkLight1337 Please review. Thanks. |
github-actions
bot
added
the
ready
This will remove below error Setuptools>=77.0.0 requires "packaging>=24.2" to work properly. rocm-build.txt has correct but rocm.txt is missing Signed-off-by: pramkuma <Pramendra.Kumar@amd.com>
&& pip install setuptools_scm is redundant Signed-off-by: pramkuma <Pramendra.Kumar@amd.com>
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com> Signed-off-by: pramkuma <Pramendra.Kumar@amd.com>
This will remove below error Setuptools>=77.0.0 requires "packaging>=24.2" to work properly. rocm-build.txt has correct but rocm.txt is missing Signed-off-by: pramkuma <Pramendra.Kumar@amd.com>
&& pip install setuptools_scm is redundant Signed-off-by: pramkuma <Pramendra.Kumar@amd.com>
|
will create fresh as facing signed off issue. closing this one. |
5 participants
This PR contains two changes
1.
This will remove below error
Setuptools>=77.0.0 requires "packaging>=24.2" to work properly.
rocm-build.txt has correct but rocm.txt is missing
2. remove redundant from dockerfile which is already present in *.txt file
pip install setuptools_scm