Update GLM-4.5 Doc transformers version #25830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zRzRzRzRzRzRzR <2448370773@qq.com>
zRzRzRzRzRzRzR
requested review from
DarkLight1337 and
ywang96
as code owners
mergify
bot
added
documentation
youkaichao
approved these changes
Sep 28, 2025
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the documentation and configuration to add support for GLM-4.6 models and bumps the minimum transformers version for GLM-4.5. The changes are generally good and consistent. I have one suggestion to improve the clarity of the supported models documentation.
| | `GlmForCausalLM` | GLM-4 | `zai-org/glm-4-9b-chat-hf`, etc. | ✅︎ | ✅︎ | ✅︎ | | ||
| | `Glm4ForCausalLM` | GLM-4-0414 | `zai-org/GLM-4-32B-0414`, etc. | ✅︎ | ✅︎ | ✅︎ | | ||
| | `Glm4MoeForCausalLM` | GLM-4.5 | `zai-org/GLM-4.5`, etc. | ✅︎ | ✅︎ | ✅︎ | | ||
| | `Glm4MoeForCausalLM` | GLM-4.5, GLM-4.6 | `zai-org/GLM-4.5`, etc. | ✅︎ | ✅︎ | ✅︎ | |
Contributor
There was a problem hiding this comment.
While the 'Models' column has been updated to include GLM-4.6, the 'Example HF Models' column still only lists zai-org/GLM-4.5. To improve clarity and consistency for users, please consider adding a GLM-4.6 model to the examples as well.
Suggested change
| | `Glm4MoeForCausalLM` | GLM-4.5, GLM-4.6 | `zai-org/GLM-4.5`, etc. | ✅︎ | ✅︎ | ✅︎ | | |
| | `Glm4MoeForCausalLM` | GLM-4.5, GLM-4.6 | `zai-org/GLM-4.5`, `zai-org/GLM-4.6`, etc. | ✅︎ | ✅︎ | ✅︎ | |
DarkLight1337
approved these changes
Sep 28, 2025
github-actions
bot
added
the
ready
ywang96
approved these changes
Sep 28, 2025
baonudesifeizhai
pushed a commit
to baonudesifeizhai/vllm
that referenced
this pull request
Sep 28, 2025
Signed-off-by: zRzRzRzRzRzRzR <2448370773@qq.com> Signed-off-by: baonudesifeizhai <baonudesifeizhai@gmail.com>
pdasigi
pushed a commit
to pdasigi/vllm
that referenced
this pull request
Oct 2, 2025
Signed-off-by: zRzRzRzRzRzRzR <2448370773@qq.com>
yewentao256
pushed a commit
that referenced
this pull request
Oct 3, 2025
Signed-off-by: zRzRzRzRzRzRzR <2448370773@qq.com> Signed-off-by: yewentao256 <zhyanwentao@126.com>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 10, 2025
Signed-off-by: zRzRzRzRzRzRzR <2448370773@qq.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
lywa1998
pushed a commit
to lywa1998/vllm
that referenced
this pull request
Oct 20, 2025
Signed-off-by: zRzRzRzRzRzRzR <2448370773@qq.com>
alhridoy
pushed a commit
to alhridoy/vllm
that referenced
this pull request
Oct 24, 2025
Signed-off-by: zRzRzRzRzRzRzR <2448370773@qq.com>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 24, 2025
Signed-off-by: zRzRzRzRzRzRzR <2448370773@qq.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
rtourgeman
pushed a commit
to rtourgeman/vllm
that referenced
this pull request
Nov 10, 2025
Signed-off-by: zRzRzRzRzRzRzR <2448370773@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update for GLM-4.5 Doc transformers version