Skip to content

[Misc] cache result of disable_inplace #26666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 13, 2025
Merged

[Misc] cache result of disable_inplace #26666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
403bd63
cache result of disable_inplace
bnellnm Oct 12, 2025
a04af65
fix unrelated lint error
bnellnm Oct 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions vllm/model_executor/layers/fused_moe/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# SPDX-License-Identifier: Apache-2.0
# SPDX-FileCopyrightText: Copyright contributors to the vLLM project
import functools
from math import prod

import torch
Expand Down Expand Up @@ -325,5 +326,6 @@ def activation_without_mul(activation: str) -> str:
# Torch custom ops can't deal with outputs aliasing inputs so we need to
# disable inplace for torch >= 2.9.
# See https://github.com/vllm-project/vllm/issues/26378
@functools.cache
def disable_inplace() -> bool:
return is_torch_equal_or_newer("2.9")
4 changes: 2 additions & 2 deletions vllm/model_executor/models/bert.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,8 +609,8 @@ class SPLADESparsePooler(Pooler):
def __init__(
self,
mlm_head: nn.Module,
cls_token_id: Optional[int] = 101,
sep_token_id: Optional[int] = 102,
cls_token_id: int | None = 101,
sep_token_id: int | None = 102,
pooling: str = "max",
remove_cls_sep: bool = True,
):
Expand Down