Skip to content

Conversation

@skyloevil
Copy link
Contributor

Clarify the image_grid_thw docstring for Qwen2.5-VL.

@skyloevil skyloevil requested a review from sighingnow as a code owner October 16, 2025 15:46
Signed-off-by: zitian zhao <zitian.zhao@tencentmusic.com>
@skyloevil skyloevil force-pushed the fix-qwen2-5-vl-docstring branch from 46a13ed to e0080a3 Compare October 16, 2025 15:46
@mergify mergify bot added the qwen Related to Qwen models label Oct 16, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request corrects a typo in the docstring for Qwen2_5_VLImagePixelInputs. The change removes some erroneous, copy-pasted text, which improves the clarity and correctness of the documentation. The fix is accurate and I have no further suggestions.

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup

@vllm-bot vllm-bot merged commit 7bb736d into vllm-project:main Oct 16, 2025
4 of 6 checks passed
Zhuul pushed a commit to Zhuul/vllm that referenced this pull request Oct 17, 2025
Signed-off-by: zitian zhao <zitian.zhao@tencentmusic.com>
@skyloevil skyloevil deleted the fix-qwen2-5-vl-docstring branch October 17, 2025 15:09
BoyuanFeng pushed a commit to BoyuanFeng/vllm that referenced this pull request Oct 17, 2025
Signed-off-by: zitian zhao <zitian.zhao@tencentmusic.com>
lywa1998 pushed a commit to lywa1998/vllm that referenced this pull request Oct 20, 2025
Signed-off-by: zitian zhao <zitian.zhao@tencentmusic.com>
albertoperdomo2 pushed a commit to albertoperdomo2/vllm that referenced this pull request Oct 23, 2025
Signed-off-by: zitian zhao <zitian.zhao@tencentmusic.com>
Signed-off-by: Alberto Perdomo <aperdomo@redhat.com>
alhridoy pushed a commit to alhridoy/vllm that referenced this pull request Oct 24, 2025
Signed-off-by: zitian zhao <zitian.zhao@tencentmusic.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 24, 2025
Signed-off-by: zitian zhao <zitian.zhao@tencentmusic.com>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 24, 2025
Signed-off-by: zitian zhao <zitian.zhao@tencentmusic.com>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
0xrushi pushed a commit to 0xrushi/vllm that referenced this pull request Oct 26, 2025
Signed-off-by: zitian zhao <zitian.zhao@tencentmusic.com>
Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
0xrushi pushed a commit to 0xrushi/vllm that referenced this pull request Oct 26, 2025
Signed-off-by: zitian zhao <zitian.zhao@tencentmusic.com>
Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
rtourgeman pushed a commit to rtourgeman/vllm that referenced this pull request Nov 10, 2025
Signed-off-by: zitian zhao <zitian.zhao@tencentmusic.com>
Zhathw pushed a commit to Zhathw/vllm that referenced this pull request Nov 12, 2025
Signed-off-by: zitian zhao <zitian.zhao@tencentmusic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

qwen Related to Qwen models

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants