docs(lora_resolvers): clarify multi-resolver order and storage path requirement #28153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request significantly improves the documentation for LoRA resolver plugins by providing a comprehensive README.md. The new documentation is well-structured and covers setup, usage, advanced configuration, and troubleshooting. I've identified a couple of areas where the wording could be clarified to prevent user confusion, particularly regarding storage backends and the example of a custom S3 resolver. Overall, this is a valuable documentation update.
wangchen615
force-pushed
the
docs/lora-resolvers-readme-update-20251105140751
branch
3 times, most recently
from
b23a3dc to
a88875f
Compare
…ng requirement\n\n- Incorporate two reviewer-suggested sentence updates\n- Keep wording consistent across README\n\nCo-authored-by: Gemini Review Bot <noreply@example.com> Signed-off-by: Chen Wang <Chen.Wang1@ibm.com>
wangchen615
force-pushed
the
docs/lora-resolvers-readme-update-20251105140751
branch
from
a88875f to
37ef3a9
Compare
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
|
Documentation preview: https://vllm--28153.org.readthedocs.build/en/28153/ |
hmellor
approved these changes
Nov 14, 2025
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
github-actions
bot
added
the
ready
geodavic
pushed a commit
to geodavic/vllm
that referenced
this pull request
Nov 16, 2025
…equirement (vllm-project#28153) Signed-off-by: Chen Wang <Chen.Wang1@ibm.com> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: George D. Torres <gdavtor@gmail.com>
bwasti
pushed a commit
to bwasti/vllm
that referenced
this pull request
Nov 17, 2025
…equirement (vllm-project#28153) Signed-off-by: Chen Wang <Chen.Wang1@ibm.com> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Bram Wasti <bwasti@meta.com>
devpatelio
pushed a commit
to SumanthRH/vllm
that referenced
this pull request
Nov 29, 2025
…equirement (vllm-project#28153) Signed-off-by: Chen Wang <Chen.Wang1@ibm.com> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
kitaekatt
pushed a commit
to kitaekatt/vllm
that referenced
this pull request
Dec 1, 2025
…equirement (vllm-project#28153) Signed-off-by: Chen Wang <Chen.Wang1@ibm.com> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
charlotte12l
pushed a commit
to charlotte12l/vllm
that referenced
this pull request
Dec 5, 2025
…equirement (vllm-project#28153) Signed-off-by: Chen Wang <Chen.Wang1@ibm.com> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Xingyu Liu <charlotteliu12x@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Clarify LoRA resolver plugin behavior and configuration in
vllm/plugins/lora_resolvers/README.md:Test Plan
vllm/envs.py.Test Result
vllm/envs.py.cc @joerunde @angkywilliam @jberkhahn @kfswain @simon-mo
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model. (N/A)