-
-
Notifications
You must be signed in to change notification settings - Fork 11.6k
[Docs] Update oneshot imports #28188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Update oneshot imports #28188
Conversation
|
Documentation preview: https://vllm--28188.org.readthedocs.build/en/28188/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly updates the import statement for oneshot in several documentation examples. The change from from llmcompressor.transformers import oneshot to from llmcompressor import oneshot aligns with recent library updates, ensuring that the provided code snippets are accurate and runnable for users. The changes are applied consistently across all relevant files, and I find no issues with this update.
|
cc @mgoin |
hmellor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oneshot has been added to the top level init https://github.com/vllm-project/llm-compressor/blob/main/src/llmcompressor/__init__.py
@UranusSeven please fix DCO and we can merge
c75bd1c to
d7f1c9f
Compare
Signed-off-by: UranusSeven <109661872+UranusSeven@users.noreply.github.com>
d7f1c9f to
71af998
Compare
Thanks! I've fixed DCO & rebased the PR. |
Signed-off-by: UranusSeven <109661872+UranusSeven@users.noreply.github.com>
Signed-off-by: UranusSeven <109661872+UranusSeven@users.noreply.github.com> Signed-off-by: Bhagyashri <Bhagyashri.Gaikwad2@ibm.com>
Signed-off-by: UranusSeven <109661872+UranusSeven@users.noreply.github.com> Signed-off-by: LuminolT <lumischen01@gmail.com>
Signed-off-by: UranusSeven <109661872+UranusSeven@users.noreply.github.com> Signed-off-by: jiang1.li <jiang1.li@intel.com>
Signed-off-by: UranusSeven <109661872+UranusSeven@users.noreply.github.com>
Signed-off-by: UranusSeven <109661872+UranusSeven@users.noreply.github.com>
Purpose
Fix the quant examples. The following import doesn't work anymore.
And should be changed to:
Test Plan
Test the import statement directly.
Test Result
Before this PR:
After this PR:
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.