Skip to content

fix comment typo #28802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2025
Merged

fix comment typo #28802

merged 1 commit into from
Nov 16, 2025

Conversation

@andyxning
Copy link
Contributor

@andyxning andyxning commented Nov 16, 2025 •
edited by github-actions bot
Loading

Purpose

Fix comment typo.

Test Plan

NA

Test Result

NA

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@andyxning
fix comment typo
25782f4 
Signed-off-by: Andy Xie <andy.xning@gmail.com>
gemini-code-assist[bot]
gemini-code-assist bot reviewed Nov 16, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes a typo in a comment in vllm/envs.py. The change updates the comment to accurately refer to the start-* and end* markers used by the documentation generator. The change is minor and correct.

yewentao256
yewentao256 approved these changes Nov 16, 2025
View reviewed changes
Copy link
Member

@yewentao256 yewentao256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the work!

@yewentao256 yewentao256 added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 16, 2025
@yewentao256 yewentao256 enabled auto-merge (squash) November 16, 2025 14:54
@yewentao256 yewentao256 merged commit ac1daf3 into vllm-project:main Nov 16, 2025
48 checks passed
@andyxning andyxning deleted the fix_comment_typo branch November 17, 2025 01:47
bwasti pushed a commit to bwasti/vllm that referenced this pull request Nov 17, 2025
@andyxning @bwasti
fix comment typo (vllm-project#28802)
227e7c2 
Signed-off-by: Andy Xie <andy.xning@gmail.com>
Signed-off-by: Bram Wasti <bwasti@meta.com>
bringlein pushed a commit to bringlein/vllm that referenced this pull request Nov 26, 2025
@andyxning @bringlein
fix comment typo (vllm-project#28802)
00148a1 
Signed-off-by: Andy Xie <andy.xning@gmail.com>
devpatelio pushed a commit to SumanthRH/vllm that referenced this pull request Nov 29, 2025
@andyxning @devpatelio
fix comment typo (vllm-project#28802)
2ab0124 
Signed-off-by: Andy Xie <andy.xning@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yewentao256 yewentao256 yewentao256 approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andyxning @yewentao256