[CI/Build Don't add FLASHINFER backend in test_cpu_offloading.py #29229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 22, 2025 00:48
Signed-off-by: Randall Smith <ransmith@amd.com>
Signed-off-by: Randall Smith <ransmith@amd.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
The primary change correctly makes the FLASHINFER backend conditional on the CUDA platform, which resolves the described CI failure on ROCm. This is a good fix. However, a debug print statement has been introduced in one of the test files, which should be removed before this pull request is merged.
| params = SamplingParams(temperature=0, bad_words=[bad_words_1, bad_words_2]) | ||
| output = llm.generate(PROMPT, params) | ||
| new_text = output[0].outputs[0].text | ||
| print(f"new_text={new_text}") |
Contributor
There was a problem hiding this comment.
This print statement appears to be a leftover from debugging. Such statements should be removed from test code to keep the test output clean and avoid confusion during test runs.
Signed-off-by: Randall Smith <ransmith@amd.com>
DarkLight1337
approved these changes
Nov 22, 2025
github-actions
bot
added
the
ready
ywang96
pushed a commit
to ywang96/vllm
that referenced
this pull request
Nov 23, 2025
…m-project#29229) Signed-off-by: Randall Smith <ransmith@amd.com> Co-authored-by: Randall Smith <ransmith@amd.com>
lpapavassiliou
pushed a commit
to lpapavassiliou/vllm
that referenced
this pull request
Nov 24, 2025
…m-project#29229) Signed-off-by: Randall Smith <ransmith@amd.com> Co-authored-by: Randall Smith <ransmith@amd.com>
RunkaiTao
pushed a commit
to RunkaiTao/vllm
that referenced
this pull request
Nov 24, 2025
…m-project#29229) Signed-off-by: Randall Smith <ransmith@amd.com> Co-authored-by: Randall Smith <ransmith@amd.com> Signed-off-by: Runkai Tao <rt572@physics.rutgers.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a test failure where
tests/v1/kv_offload/test_cpu_offloading.pyadds theFLASHINFERbackend to the test, but ROCm platform does not supportflashinferlibrary. Doing this allows the test to be successful in AMD CI. The test runs to completion and the result is:1 passed, 3 warnings