Skip to content

Conversation

@fadara01
Copy link
Contributor

@fadara01 fadara01 commented Nov 26, 2025

Purpose

  • Remove numa related configs from Arm CI tests: our self-hosted runners don't have numactl installed and are single numa anyways
  • Remove --privileged because our agents don't support that and we don't need it
  • Replace llama3.2-3b in serving test with qwen3-0.6b, because llama is gated and we don't yet set a HF_TOKEN.

Test Plan

Trigger a build with Arm pipeline introduced in https://github.com/vllm-project/ci-infra

Test Result

Build passes, see: https://buildkite.com/vllm/ci/builds/40820/steps/canvas?sid=019ac288-2547-45d5-b974-0cb7796cf26b

Tests Pass


Essential Elements of an Effective PR Description Checklist
  • [Y] The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • [Y] The test plan, such as providing test command.
  • [Y] The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@mergify mergify bot added the ci/build label Nov 26, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes NUMA-related configurations from the ARM CI test script, which is appropriate since the self-hosted runners do not have numactl and are single-NUMA. The changes are mostly correct and simplify the script. However, I've found a minor issue in how the test function is called, which should be corrected for clarity and robustness.

@fadara01 fadara01 force-pushed the remove_numa_from_tests branch 2 times, most recently from e75a60b to 7ac6d82 Compare November 26, 2025 23:12
Our self-hosted runners don't have `numactl` installed and are single numa anyways

Signed-off-by: Fadi Arafeh <fadi.arafeh@arm.com>
@fadara01 fadara01 force-pushed the remove_numa_from_tests branch from 7ac6d82 to ac064b9 Compare November 26, 2025 23:33
@fadara01 fadara01 changed the title [cpu][fix] Remove numa related configs from Arm CI tests [cpu][fix] Fix Arm CI tests Nov 26, 2025
@fadara01
Copy link
Contributor Author

@bigPYJ1151 @mgoin could you review this please?

@mgoin mgoin added ready ONLY add when PR is ready to merge/full CI is needed aarch64-cpu labels Nov 27, 2025
@bigPYJ1151 bigPYJ1151 added this to CPU Nov 27, 2025
@github-project-automation github-project-automation bot moved this to Backlog in CPU Nov 27, 2025
@bigPYJ1151 bigPYJ1151 removed this from CPU Nov 27, 2025
@bigPYJ1151 bigPYJ1151 merged commit ecb1952 into vllm-project:main Nov 27, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aarch64-cpu ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants