Skip to content

Conversation

@DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Nov 27, 2025

Purpose

vllm.model_executor.layers.pooler.PoolerConfig is an imported reference. It should reference vllm.config.pooler.PoolerConfig.pooling_type directly instead.

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337
Copy link
Member Author

cc @noooop

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a documentation build issue by correcting a cross-reference in a docstring. The change in vllm/model_executor/models/interfaces_base.py updates the path for PoolerConfig.pooling_type to its canonical location. This is a correct and necessary fix to ensure the documentation builds successfully. The change is approved.

Copy link
Member

@hmellor hmellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm if docs build passes

@DarkLight1337
Copy link
Member Author

Passed

@vllm-bot vllm-bot merged commit ee9841d into vllm-project:main Nov 27, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants