[Frontend] Fixes anthropic /v1/messages streaming not containing input_tokens on first chunk #29971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbartels
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request aims to add support for continuous_usage_stats to the Anthropic-compatible streaming endpoint. The implementation correctly enables the option when converting to an OpenAI request. However, there is a critical issue in how the message_start event is constructed. The usage information is placed at the top level of the event, whereas the Anthropic API specification requires it to be nested within the message object. I've provided a suggestion to correct this, ensuring API compliance.
bbartels
changed the title
Member
|
Can you add a regression test? |
Signed-off-by: bbartels <benjamin@bartels.dev>
bbartels
requested review from
DarkLight1337,
NickLucche and
robertgshaw2-redhat
as code owners
Contributor
Author
|
@DarkLight1337 added a test |
github-actions
bot
added
the
ready
PatrykSaffer
pushed a commit
to PatrykSaffer/vllm
that referenced
this pull request
Dec 4, 2025
…t_tokens on first chunk (vllm-project#29971) Signed-off-by: bbartels <benjamin@bartels.dev>
charlotte12l
pushed a commit
to charlotte12l/vllm
that referenced
this pull request
Dec 5, 2025
…t_tokens on first chunk (vllm-project#29971) Signed-off-by: bbartels <benjamin@bartels.dev> Signed-off-by: Xingyu Liu <charlotteliu12x@gmail.com>
5 tasks
charlotte12l
pushed a commit
to charlotte12l/vllm
that referenced
this pull request
Dec 9, 2025
…t_tokens on first chunk (vllm-project#29971) Signed-off-by: bbartels <benjamin@bartels.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.