Skip to content

feat(ui): upgrade Form with validation wrapper#147

Open
bntvllnt wants to merge 8 commits intofeat/storybookfrom
feat/issue-47-feat-component-form-validation-wrapper
Open

feat(ui): upgrade Form with validation wrapper#147
bntvllnt wants to merge 8 commits intofeat/storybookfrom
feat/issue-47-feat-component-form-validation-wrapper

Conversation

@bntvllnt
Copy link
Copy Markdown
Collaborator

Summary

  • upgrade Form from a presentational wrapper into a react-hook-form-powered validation shell with schema/resolver support
  • add accessible field wiring helpers (FormField, FormControl, FormDescription, FormMessage, useFormField) and export them for consumers
  • add docs, stories, tests, and visual coverage for validation, pending submit state, and accessible error messaging

Validation

  • pnpm -F @vllnt/ui exec vitest run src/components/form/form.test.tsx
  • pnpm -F @vllnt/ui exec tsx scripts/verify-stories.ts
  • pnpm -F @vllnt/ui exec playwright test -c playwright-ct.config.ts src/components/form/form.visual.tsx
  • pnpm -F @vllnt/ui build

Closes #47

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
storybook Ready Ready Preview, Comment Apr 25, 2026 7:28pm
ui.vllnt.ai Ready Ready Preview, Comment Apr 25, 2026 7:28pm

Request Review

@bntvllnt bntvllnt marked this pull request as ready for review April 25, 2026 02:31
@bntvllnt

This comment has been minimized.

@bntvllnt

This comment has been minimized.

@bntvllnt

This comment has been minimized.

@bntvllnt

This comment has been minimized.

@bntvllnt
Copy link
Copy Markdown
Collaborator Author

Status: ready for final human review.

Blockers: none.

Validation summary:

  • pnpm install --frozen-lockfile
  • pnpm -F @vllnt/ui exec vitest run src/components/form/form.test.tsx
  • pnpm -F @vllnt/ui exec tsx scripts/verify-stories.ts
  • pnpm -F @vllnt/ui build
  • pnpm --dir apps/registry build
  • pnpm -F @vllnt/ui exec playwright test -c playwright-ct.config.ts src/components/form/form.visual.tsx
  • gh pr checks 147 (Vercel Preview Comments, storybook, ui.vllnt.ai all passing)

Claude review result:

  • No blocking findings on the live diff vs feat/storybook.
  • Non-blocking warns only: TS as escape hatches in form.tsx, always-instantiated useForm when a form instance is provided, auto-disable-on-submit behavior/documentation drift, and dependency/peer-dependency follow-up questions for RHF/Zod.

Codex review result:

  • Unavailable for this run: codex CLI is installed, but OPENAI_API_KEY is unset, so no Codex review could be executed.

Action for bntvllnt:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant