feat(seo): add sitemap.ts enumerating routes + 225 components (#234)#291
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
3 tasks
bntvllnt
added a commit
that referenced
this pull request
May 10, 2026
## Problem PR #288 (the #266 a11y fix) added \`aria-controls\`, \`aria-haspopup\`, and a \`React.useId()\` hook to the combobox. Those additions pushed the \`forwardRef\` arrow function from 70 → 71 lines, tripping the project's \`max-lines-per-function\` rule (limit 70). Every PR branched from main after #288 inherits the lint failure on \`Quality Gates → Lint\` — currently blocking #290 (#233 robots) and #291 (#234 sitemap). ## Fix Extract the \`<PopoverContent>\` + \`<Command>\` + \`<CommandList>\` JSX into a local \`ComboboxListPanel\` component. Pure structural refactor — no runtime behavior change. Both consumers (\`packages/ui\` source and \`apps/registry/registry/default\` copy) kept aligned per #266 / #269. | Metric | Before | After | |---|---|---| | forwardRef arrow body | 71 lines | **52 lines** | | Block including signature + closing | 73 lines | 62 lines | ## Validation - Refactor preserves all ARIA attributes, refs, and event wiring. - Both files stay byte-identical in semantic structure. - Local \`wc -l\`: forwardRef block now 62 lines. ## Test plan - [ ] CI \`Quality Gates → Lint\` passes on this PR. - [ ] After merge, #290 and #291 re-run and lint passes. - [ ] Combobox visual stories unchanged. Refs #266 Co-authored-by: bntvllnt <bntvllnt@users.noreply.github.com>
Next.js MetadataRoute.Sitemap emitted from app/sitemap.ts: - 4 static routes (home, /components, /docs, /philosophy) with priorities 1.0 / 1.0 / 0.8 / 0.6. - 225 dynamic /components/<name> entries generated from registry.json (priority 0.7). - Raw registry endpoints: /r/registry.json + /r/<name>.json (priority 0.3, indexed for agent discovery). Total ≈ 455 URLs after deploy. Linked from robots.ts (#233). Closes #234
bntvllnt
force-pushed
the
feat/234-sitemap-routes
branch
from
642bf89 to
ada7185
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
apps/registry/app/sitemap.tsemitting a programmatic sitemap fromregistry.json./,/components,/docs,/philosophy)/components/<name>)/r/registry.json+ per-item/r/<name>.json)Why include /r/*.json?
Agents (Cursor, Claude, Continue) discover the library via these endpoints. Listing them in the sitemap (low priority) makes them crawlable without polluting search-engine ranking signal.
Validation
registry.jsonvia Next.js JSON module support.next/MetadataRoute.Sitemap.lastModifiedset at request time so re-deploys refresh dates.Test plan
curl -s https://ui.vllnt.ai/sitemap.xml | xmllint --noout -passes (valid XML)./components/button) appears withpriority=0.7.Depends on
Closes #234