fix(react-doctor): rename generic handlers#339
Open
bntvllnt wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
bntvllnt
added
react-doctor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
react-doctor/no-generic-handler-nameshandler definitions inpackages/uito action-oriented names while preserving DOM event prop names./r/*sources mirror the package changes.onClickordering,defaultPreventedguards, callback payloads, and event propagation behavior.Closes #276
Related to #279
Validation
pnpm doctor:json && jq '[.diagnostics[] | select(.rule == "no-generic-handler-names")] | length' .react-doctor.jsonPASS (0)pnpm -F @vllnt/ui exec eslint <changed package files>PASSpnpm -F @vllnt/ui lintPASSpnpm -F @vllnt/ui exec tsc --noEmit --project tsconfig.build.jsonPASSpnpm buildPASSpnpm test:oncePASS (216 files, 1215 tests)git diff --checkPASSNotes:
pnpm buildemitted the existing Next.js multiple-lockfile warning for this nested worktree. Vitest emitted existing jsdom navigation, duplicate-key, and Radix dialog-description warnings while passing.Design Deviations
None.