Skip to content

fix(react-doctor): clear state and effect warnings#345

Open
bntvllnt wants to merge 1 commit into
mainfrom
fix/271-state-effects
Open

fix(react-doctor): clear state and effect warnings#345
bntvllnt wants to merge 1 commit into
mainfrom
fix/271-state-effects

Conversation

@bntvllnt
Copy link
Copy Markdown
Collaborator

Summary

Validation

  • pnpm -F @vllnt/ui lint
  • pnpm -F @vllnt/ui exec tsc --noEmit --project tsconfig.build.json
  • pnpm -F @vllnt/ui-registry exec tsc --noEmit --project tsconfig.json
  • pnpm build
  • pnpm test:once
  • git diff --check
  • git diff --cached --check
  • npx --yes react-doctor . --offline --json (targeted react-doctor: state & effects — derived state, cascading setState, effect-event handlers (41 warnings) #271 rules = 0)
  • npx --yes react-doctor . --diff origin/main --annotations --fail-on error --offline (exits 0; non-target warnings remain from other tracked issue families)

Notes

  • Kept the event helper React 18-compatible instead of using React 19 useEffectEvent because @vllnt/ui peers react >=18.0.0.
  • Build still prints the known Next.js multiple-lockfile root warning in worktrees.
  • Tests still print known jsdom navigation, ShareDialog Description, and InteractiveTimeline duplicate-key warnings.

Closes #271

@bntvllnt bntvllnt self-assigned this May 13, 2026
@vercel
Copy link
Copy Markdown

vercel Bot commented May 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
storybook Ready Ready Preview, Comment May 13, 2026 0:06am
ui.vllnt.ai Ready Ready Preview, Comment May 13, 2026 0:06am

Request Review

@bntvllnt bntvllnt added bug Something isn't working react-doctor Reported by react-doctor (codebase health) tech-debt Refactoring or cleanup labels May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working react-doctor Reported by react-doctor (codebase health) tech-debt Refactoring or cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

react-doctor: state & effects — derived state, cascading setState, effect-event handlers (41 warnings)

1 participant