ci: run issue-link gate on pull requests#375
Open
bntvllnt wants to merge 1 commit into
Open
Conversation
|
Preview ready · Updated 2026-05-20T14:42:13Z
Inspect
|
bntvllnt
commented
May 20, 2026
Collaborator
Author
bntvllnt
left a comment
There was a problem hiding this comment.
Review — PR #375 at d9f21b1
BLOCKING
- None in the PR diff.
WARN
- None for the PR code/config change. The earlier/shared ui-registry deployer issue is not a PR #375 diff finding and remains tracked separately; live checks now show the ui-registry deploy job passing on this head.
VERIFIED CLEAN
- Reconciled the prior full-diff review evidence for the unchanged current head.
- Changed-file coverage is complete:
.github/workflows/pr-issue-link.ymlis the only changed file (+1/-1). - The workflow now runs on
pull_requestinstead ofpull_request_target, preserving the issue-link activity types and read-only permissions. - The workflow still does not check out or execute PR-controlled code.
- PR metadata still matches the bounded scope: one workflow trigger change for the issue-link gate.
VALIDATION
- Live preflight: PR is OPEN, non-draft, head is still
d9f21b1494c4440d146a70f0297c13c9718730ad, base ismain, and there were no existing GitHub review artifacts before this comment review. - Live checks observed before publication: 9 pass, 1 cancelled concurrency-noise issue-link run; latest
Enforce issue-linked PRs, Quality Gates, CodeQL, Storybook, preview deploy, and ui-registry deploy were passing. - Re-read the live patch and workflow contents at the current head; invariant check passed for
pull_requestpresent,pull_request_targetabsent, expected activity types preserved, and noactions/checkout.
Approval is recommended from this review evidence, but final APPROVE and merge remain reserved for bntvllnt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pull_request_targettopull_requestso the eventual required check is produced on the PR head SHA.Enforce issue-linked PRsjob/check name.Validation
git diff --check— passed ond9f21b1494c4440d146a70f0297c13c9718730ad.python3invariant check — passed: nopull_request_target,pull_requestpresent, read-only permissions preserved, check name preserved, noactions/checkout.python3+ PyYAML parse — passed.Current CI status
Enforce issue-linked PRs— passing ond9f21b1494c4440d146a70f0297c13c9718730ad.build · sign · scan · deploy (ui-registry)— failing in deployer config outside this PR's diff: deployer returnsparse /etc/***/apps/ui-registry/app.yaml: yaml: unmarshal errors ... field dockerfile/context not found in type apps.Source.Enforce issue-linked PRsrun was cancelled by workflow concurrency; the later run on the same head passed.Risk notes
Related to #152