fix: ensure compatability with werkzeug 3.0.0#20
Conversation
|
@vmalloc can you review this PR? |
|
@LiadOz Sure, sorry that it slipped underneath the radar within all my notifications. Can you explain what the problem is and why this actually fixes it? Thanks in advance! |
|
The cookie_jar attribute was removed from the Werkzeug Client class. So it can't be used anymore. However, it's not really needed, since we already forward the |
|
Is it backwards compatible with older versions of Werkzeug/flask? |
|
Werkzeug versions prior to 1.0.0 could have issues, it introduced some changes with cookies handling and I tested using that version. Should I add a version marker for it? |
|
At least worth constraining the version so that the conflict is clear to whomever installs it then |
954f7de to
2736149
Compare
done |
|
Thanks @LiadOz ! |
|
@vmalloc Are you planning to release a new version of flask-loopback to pypi? I can set up a release job if you need. |
|
Hi! That would be greatly appreciated if you're up for it |
I have disabled the internal cookies that the test client uses. When use_cookies is True, it overrides the cookie header that is passed with open_kwargs to the open function, so after setting use_cookies to False, there is no need to change the cookies. This is tested with in
tests/test_cookies.py.I took the liberty of adding a github workflow and removing old versions from setup.cfg, let me know if this should be changed.