🐛 [Bug] Block while shield sheathed.

[Daribon]

🐛 Bug report

You can currently block with shield sheathed.

Expected behavior

On classic you have to have shield unsheathed, if you want to block a hit.
Any hit while your shield is not in your hand, will not be possible to block on classic.

The only thing I have from vanilla is from the spell attribute of the block spell in 1.12.1:
SPELL_ATTR_DO_NOT_SHEATH

It only exists in SpellDefines.h but nowhere else.

Steps to reproduce

1. Have your shield sheathed.
2. Go near any enemy mob.
3. Hits will be blocked while shield is sheathed.
4. Profit

Version & Environment

Client Version: 1.12.1.5875

Commit Hash: 4e9b446

OS Client: Windows 11 Pro N 10.0.22621.1413
OS Server: Windows 11 Pro N 10.0.22621.1413

Crashlog

• None

[Wall-core]

this should actually replace the code that prevents blocking AND parrying while casting, mounted, etc.
The spell being cast should determine whether or not the player is able to block or parry while casting via the automatic sheathing of the weapon/shield. Some spells with cast time do not prevent blocking as they do not sheathe weapon or shield.

[BinBreton]

https://warcraft.wiki.gg/wiki/Patch_2.1.0_(undocumented_changes)
You can now block attacks while your shield is in the sheathed position. Previously, Warriors, Shamans and Paladins were vulnerable while using instant-cast abilities that caused their shield to momentarily appear on their back.

[ratkosrb]

vid.2024-08-28-1423-34.mp4

I can't reproduce it on classic. I don't have my shield or melee weapon drawn yet I can block and parry attacks.

[ratkosrb]

We'll assume the TBC patch notes to be true, and if someone finds video proof from vanilla of blocking without having shield drawn we'll revert it.

[ratkosrb]

Okay I performed a better test and I understood how it works. It's specifically in unarmed sheath state that you can't block. In ranged state you can still block. Also it does not affect parry.

vid.2024-08-28-1454-05.mp4

[ratkosrb]

707c9c9