-
Notifications
You must be signed in to change notification settings - Fork 536
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
🐛 Bug report
Building for 1.6.1.4544 is currently failing:
/core/src/game/Objects/Player.cpp: In member function 'InventoryResult Player::CanUnequipItem(uint16, bool) const':
/core/src/game/Objects/Player.cpp:10335:16: error: 'EQUIP_ERR_NOT_WHILE_DISARMED' was not declared in this scope
10335 | return EQUIP_ERR_NOT_WHILE_DISARMED;
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
Full context here (the output is alternating between the x86_64 and aarch64 builds which is why it looks so discontinuous).
I assume the error occurs due to this addition in 2f500b9:
core/src/game/Objects/Player.cpp
Lines 10333 to 10335 in ce50f98
| // you cannot unequip main hand weapon while disarmed | |
| if (IsMainHandPos(pos) && HasFlag(UNIT_FIELD_FLAGS, UNIT_FLAG_DISARMED)) | |
| return EQUIP_ERR_NOT_WHILE_DISARMED; |
Because EQUIP_ERR_NOT_WHILE_DISARMED is not defined when building for 1.6.1.4544:
Lines 108 to 109 in ce50f98
| #if SUPPORTED_CLIENT_BUILD > CLIENT_BUILD_1_6_1 | |
| EQUIP_ERR_NOT_WHILE_DISARMED, // ERR_NOT_WHILE_DISARMED |
Commit Hash: ce50f98
OS Server: Ubuntu 24.04 LTS
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working