Translate comments in SpellAuras.cpp from French to English#2755
Conversation
- Translate some easy comments. Some like "Onyxia buff" are ambiguous
|
Just in case you want to translate even more stuff: (Reminds me of the Futurama gag https://www.youtube.com/watch?v=pwODwwgE6rA 🤣) |
What does PSendSysMessage do? Are there scripts or something that depend on those values being OUI/NON? |
|
|
|
I know that people do things like write scripts to parse combat log messages which is why I asked. I'll make a separate PR for it just in case. |
- Translate a couple of small comments - Expand comment about Gobl/Gnomish Rocket Boot probabilities. FIXME: Research this on retail
- Google translated a comment that seemed more conversational than technical, since I was unsure of its intent - Expand description of Ghost Wolf/Water Walking interaction
|
@0blu Are you able to review this PR? No rush at all, I just want to make sure it's not in limbo since it started as a draft |
|
I don't think he speaks French to be able to review it. |
| @@ -952,6 +952,7 @@ bool Aura::CanProcFrom(SpellEntry const* spell, uint32 EventProcEx, uint32 procE | |||
| uint64 mask = sSpellMgr.GetSpellAffectMask(GetId(), GetEffIndex()); | |||
|
|
|||
| // Nostalrius: c'est la moindre des choses d'utiliser un peu 'spell_proc_event' non ? | |||
There was a problem hiding this comment.
Can you please replace this too, no need to put the translation below it.
Although I am unsure what this means in this context.
@ratkosrb maybe you can give us a bit of context.
There was a problem hiding this comment.
Yeah I was confused about what this means. I took it as more of a conversational note rather than explaining what the code was doing, so I wasn't sure whether to translate it at all or just leave it as-is
Co-authored-by: _BLU <dot0blu@gmail.com>
| case 18192: // Increased Agility | ||
| case 18191: // Increased Stamina | ||
| case 25661: // Increased Stamina | ||
| case 24427: // Toasty |
There was a problem hiding this comment.
Why was this changed to Toasty? Spell 24427 is Diamond Flask.
There is no spell named Toasty in vanilla.
There was a problem hiding this comment.
I pulled the data for these comments straight from the vmangos database. It looks like it was called Toasty in one of the older builds. I can try to write a query to only pull the latest names if that's most useful.
| name | build |
|---|---|
| Toasty | 4695 |
| Diamond Flask | 4878 |
| Diamond Flask | 5302 |
ghost
mentioned this pull request
4 participants
🍰 Pullrequest
Working on translating aura descriptions from french to english
Issues
Todo / Checklist