Add Ashenvale Creature Waypoints (credit cmangos)

[NickTyrer]

🍰 Pullrequest

[ratkosrb]

The bear with guid 8157 goes through a building.

[NickTyrer]

That is blizzlike.

[mserajnik]

Is this some temporary issue on GitHub Actions side?

Edit: Oh yeah, seems to be a general issue right now: https://www.githubstatus.com/incidents/gnftqj9htp0g

[ratkosrb]

@NickTyrer Are you aware that you have replaced many unrelated creatures around the world?

For example guid 8169 which you replaced was Grimand Elmore (1416) located in Stormwind City, and you replaced him with an Ashenvale Bear. You deleted the old spawn and replaced it. Is this intentional, was the spawn of Grimand Elmore a wrong duplicate?

[ratkosrb]

Here are all the cases where a guid was replaced in this PR with a different creature id. A lot of the time the mobs replaced are not even in the same continent.

[ratkosrb]

You should never have a DELETE in your queries before an INSERT, unless you know a spawn with this guid existed and you are replacing it on purpose. Never add a DELETE as precautionary measure so that it can forcibly execute in case there's a future guid conflict.

[NickTyrer]

Sorry, was a copy pasta mistake. I forgot to remove DELETE FROM creature WHERE guid IN(@MOVID);

[ratkosrb]

Will you go through all the replaced guids and determine if they should have been replaced or was it a mistake?

[NickTyrer]

I just used a block of free guids here https://github.com/vmangos/core/pull/3379/changes#diff-2db6f83a4c1eaa56af0b292e17a6a35b108533f57d6fbe357080d5e1eed498ecR11

[NickTyrer]

A couple of places use direct guid replacement like https://github.com/vmangos/core/pull/3379/changes#diff-2db6f83a4c1eaa56af0b292e17a6a35b108533f57d6fbe357080d5e1eed498ecR194. These are correct

[NickTyrer]

I will test it again just to verify.

[ratkosrb]

CI fails

ERROR 1062 (23000) at line 413481: Duplicate entry '8166' for key 'PRIMARY'