add snake case fortmatting to PK upon table creation#12
Open
Neliitsme wants to merge 1 commit intovmkteam:masterfrom
Open
add snake case fortmatting to PK upon table creation#12Neliitsme wants to merge 1 commit intovmkteam:masterfrom
Neliitsme wants to merge 1 commit intovmkteam:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10
I checked around the code, it seems that snake_case is being used as default in other places so i defaulted to that too.
Other than that i suppose it could be done better by checking for other conventions too, currently the code doesn't differentiate between camel and pascal cases either and just uses the table name capitalization. I din't go through with fixing it since it could be intended behavior.
Also the frontend doesn't seem to be following any sort of formatting as when i ran
npm run formati got changes in a bunch of files. Just something to keep in mind.Let me know what you think.