fix: warn on duplicate column names in CSV header#105
Merged
Conversation
When the CSV header contains duplicate column names, emit a warning to stderr for each rename (e.g. warning: duplicate column "value" renamed to "value_2"). Warnings are always written to stderr so they never corrupt stdout output. Closes #80
vmvarela
added
type:bug
github-actions
bot
added
type:feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
warning: duplicate column "<original>" renamed to "<new>"to stderr when CSV headers contain duplicate column namesstd.log.errfollowing existing project conventionsChanges
src/main.zig:parseHeadernow accepts astderr_writerparameter; when deduplication renames a column, a warning line is printed to stderrbuild.zig: Two new integration tests — one verifying the warning appears on stderr, another verifying stdout remains cleanCloses #80