fix: pass -Dbundle-sqlite=true to unit-test step in CI#137
Merged
Conversation
On Windows there is no system sqlite3 library, so xml.zig unit tests fail with 'unable to find dynamic system library sqlite3'. The SQLite amalgamation is already downloaded before this step, so bundling it is both correct and sufficient on all platforms. Closes #136
vmvarela
added
type:bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
zig build unit-testfailed on Windows becausexml.zigtests link against sqlite3, which has no system library on Windows-Dbundle-sqlite=trueto the unit-test step makes it use the already-downloaded SQLite amalgamation, consistent with the build stepCloses #136