perf: replace byte-by-byte takeByte() with block reads in xml.zig and json.zig#150
Merged
Merged
Conversation
… json.zig Replace the tight takeByte() loops that read stdin one byte at a time with reader.allocRemaining(allocator, .unlimited), which issues a single bulk read using the Io vtable dispatch instead of one dispatch per byte. Functions updated: - xml.zig: loadXmlInput, getXmlColumnNames, summarizeXml - json.zig: loadJsonArray No API changes; all existing tests continue to pass. Closes #135
vmvarela
added
type:chore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
takeByte()loops that read stdin one byte at a time withreader.allocRemaining(allocator, .unlimited), which issues a single bulk read through the Io vtableFunctions updated
src/xml.zig:loadXmlInput,getXmlColumnNames,summarizeXmlsrc/json.zig:loadJsonArrayNote on
readLinein json.zigThe
readLinefunction (NDJSON line reader) usestakeByte()for a different purpose — reading until\n— and is intentionally left unchanged, as it cannot be replaced withallocRemaining.Closes #135