This repository was archived by the owner on Mar 6, 2024. It is now read-only.
Add support to escape special characters in query filter for api v35.0+#711
Merged
Conversation
…0 and above Signed-off-by: rocknes <aritra.iitkgp@gmail.com>
shashim22
approved these changes
Sep 30, 2020
Contributor
shashim22
left a comment
There was a problem hiding this comment.
Reviewed 9 of 9 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Signed-off-by: rocknes <aritra.iitkgp@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For api v35.0+, vCD requires special characters viz. ( ) ; , to be escaped if used as value in query filter.
In _AbstractQuery, we escape the special characters in encoded filter value.
Additional changes,
Testing done:
Ran all vcd-cli commands that invoke the affected methods at api v35.0 and made sure that all these commands returned expected result.
This change is