This repository was archived by the owner on May 18, 2026. It is now read-only.
Adding capability to set serviceAccountName through flags#117
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
warango4
force-pushed
the
issue83
branch
2 times, most recently
from
e216b91 to
148cd1f
Compare
shashwathi
reviewed
May 16, 2022
In this feature, serviceAccountName is added as a flag and can be used in create/update/apply commands. To delete serviceAccountName from workload, the flag should be set to "" or '' E.g. - tanzu apps workload create rmq-sample-app --git-repo https://github.com/jhvhs/rabbitmq-sample --git-branch main --type web --service-account myServiceAccount -y - tanzu apps workload apply rmq-sample-app --service-account myServiceAccountUpdated -y // When retrieving the workload, the new service account name should be 'myServiceAccountUpdated' - tanzu apps workload update rmq-sample-app --service-account "" -y // Should delete serviceAccountName from workload Signed-off by: Wendy Arango warango@vmware.com
rashedkvm
reviewed
May 17, 2022
Member
rashedkvm
left a comment
rashedkvm
left a comment
There was a problem hiding this comment.
How does the user know to use an empty string so an existing serviceAccountName value can be removed?
shashwathi
reviewed
May 17, 2022
Signed-off by: Wendy Arango warango@vmware.com
shashwathi
approved these changes
May 17, 2022
rashedkvm
approved these changes
May 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
What this PR does / why we need it
In this feature, serviceAccountName is added as a flag and can be used in create/update/apply commands.
To delete serviceAccountName from workload, the flag should be set to "" or ''
E.g.
tanzu apps workload create rmq-sample-app --git-repo https://github.com/jhvhs/rabbitmq-sample --git-branch main --type web --service-account myServiceAccount -ytanzu apps workload apply rmq-sample-app --service-account myServiceAccountUpdated -y // When retrieving the workload, the new service account name should be 'myServiceAccountUpdated'tanzu apps workload update rmq-sample-app --service-account "" -y // Should delete serviceAccountName from workloadWhich issue(s) this PR fixes
Fixes #83
Describe testing done for PR
Additional information or special notes for your reviewer
Signed-off by: Wendy Arango warango@vmware.com