This repository was archived by the owner on May 18, 2026. It is now read-only.
Add support for jar/zip format for local-path flag#121
Merged
Conversation
shashwathi
commented
May 18, 2022
| defer os.RemoveAll(zipContentsDir) | ||
| contentDir = zipContentsDir | ||
| } else { | ||
| return false, fmt.Errorf("unsupported file format %q", opts.LocalPath) |
Contributor
Author
There was a problem hiding this comment.
cc @danfein : this is the error if user provides a file which is not a dir and not a valid zip file. If you want something else, please add the msg here
rashedkvm
reviewed
May 18, 2022
warango4
reviewed
May 18, 2022
warango4
approved these changes
May 18, 2022
rashedkvm
approved these changes
May 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Add support for jar/zip format for local-path flag
Which issue(s) this PR fixes
Fixes #29
Describe testing done for PR
Download simple java jar file and build zip file(using
zipcli).