This repository was archived by the owner on May 18, 2026. It is now read-only.
feat: support json/yaml param using new flag --param-yaml#124
Merged
rashedkvm merged 1 commit intoMay 24, 2022
Conversation
Contributor
|
I think we should fail if the input is not a valid json or yaml for the |
3863d4a to
93e5388
Compare
Contributor
Author
You are right, updated to fail on invalid json/yaml |
shashwathi
reviewed
May 18, 2022
scothis
reviewed
May 18, 2022
262e947 to
9a30809
Compare
Contributor
Author
Added some test |
scothis
reviewed
May 19, 2022
9a30809 to
d05b84d
Compare
shashwathi
reviewed
May 19, 2022
shashwathi
reviewed
May 19, 2022
28ef679 to
4048cdf
Compare
shashwathi
approved these changes
May 20, 2022
2fd3a97 to
da8182e
Compare
rashedkvm
reviewed
May 23, 2022
Member
rashedkvm
left a comment
There was a problem hiding this comment.
Question: Is nested yaml for params supported from workload file instead of flag? For workload apply and workload create can you add a test where the yaml file contains the nested yaml.
Signed-off-by: Diego Alfonso <dalfonso@vmware.com>
da8182e to
18c9063
Compare
rashedkvm
approved these changes
May 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
What this PR does / why we need it
Adds support for JSON and YAML notation values of parameters through the new flag
--param-yamlwhich has the same behavior as the existing--parambut the value only supports valid JSON/YAML otherwise the command will failWhich issue(s) this PR fixes
Fixes #103
Describe testing done for PR
Local sandbox for CLI against TAP 1.1 cluster:
Create a workload:
Invalid json/yaml and help message

Creating Workload

Removing param

Updating param

Exporting the wld

Additional information or special notes for your reviewer