This repository was archived by the owner on May 18, 2026. It is now read-only.
Add -s as shorthand for --source-image#129
Merged
Merged
Conversation
Contributor
Author
|
|
Contributor
Author
|
|
shashwathi
approved these changes
May 23, 2022
atmandhol
approved these changes
May 25, 2022
Signed-off by: Wendy Arango warango@vmware.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
What this PR does / why we need it
Remove
-sas shorthand for--service-accountand add it for--source-imageWhich issue(s) this PR fixes
Fixes #126
Describe testing done for PR
-sand passing a source image after flag$ tanzu apps workload create petclinic-local --local-path . -s gcr.io/tanzu-framework-playground/petclinic-local --type webgcr(or whichever registry) repository to publish sourceAdditional information or special notes for your reviewer
Signed-off by: Wendy Arango warango@vmware.com