This repository was archived by the owner on May 18, 2026. It is now read-only.
feat: added suport for exclude files on local path#145
Merged
Conversation
odinnordico
force-pushed
the
issue-33-exclude-local
branch
from
a117f4e to
cbecb7f
Compare
odinnordico
force-pushed
the
issue-33-exclude-local
branch
from
cbecb7f to
bfa01a5
Compare
shashwathi
reviewed
May 31, 2022
Contributor
shashwathi
left a comment
shashwathi
left a comment
There was a problem hiding this comment.
Overall looks good. I would add some more unit tests to make sure we have coverage for diff file paths in tanzuignore file
odinnordico
force-pushed
the
issue-33-exclude-local
branch
from
bfa01a5 to
9940dfa
Compare
shashwathi
approved these changes
May 31, 2022
shashwathi
reviewed
May 31, 2022
odinnordico
force-pushed
the
issue-33-exclude-local
branch
2 times, most recently
from
71a8af5 to
b81f5ec
Compare
shashwathi
reviewed
Jun 1, 2022
Co-authored-by: Wendy Maria Arango Chavarria <warango@vmware.com> Signed-off-by: Diego Alfonso <dalfonso@vmware.com>
odinnordico
force-pushed
the
issue-33-exclude-local
branch
from
b81f5ec to
8ec77b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
What this PR does / why we need it
Add support to exclude files when creating/updating a workload from
--local-sourceusing the file.tanzuignore.Which issue(s) this PR fixes
Fixes #33
Describe testing done for PR
Testing on local box against Tap 1.0.2 cluster with local java project
tanzu apps wld apply tanzu-java-web-app-2-6-0 --local-path . --source-image dalfonso901/tanzu-java-web-app-2-6-local --label autoscaling.knative.dev/min-scale=1 --type webAdditional information or special notes for your reviewer
There is a missing integration test to verify the final image comes without excluded files