Skip to content
This repository was archived by the owner on May 18, 2026. It is now read-only.

Delete info message pointing to workload get after wait error#192

Merged
rashedkvm merged 1 commit into
vmware-tanzu:mainfrom
warango4:issue183
Jun 23, 2022
Merged

Delete info message pointing to workload get after wait error#192
rashedkvm merged 1 commit into
vmware-tanzu:mainfrom
warango4:issue183

Conversation

@warango4
Copy link
Copy Markdown
Contributor

Pull request

What this PR does / why we need it

remove redundant message pointing to workload get when there is an error after wait in workload create/update/apply

Which issue(s) this PR fixes

Fixes #183

Describe testing done for PR

  • Updated unit testing
  • Checked commands behaviour in local cluster

Additional information or special notes for your reviewer

Signed-off-by: Wendy Arango warango@vmware.com

@warango4
Copy link
Copy Markdown
Contributor Author

image

@warango4 warango4 requested review from rashedkvm and shashwathi and removed request for shashwathi June 21, 2022 17:04
Comment thread pkg/dies/cartographer/v1alpha1/zz_generated.die.go
Copy link
Copy Markdown
Contributor

@shashwathi shashwathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest looks good. Remove dies changes from this Pr and create diff PR for that

Signed-off-by: Wendy Arango <warango@vmware.com>
@rashedkvm rashedkvm merged commit 72d5cc5 into vmware-tanzu:main Jun 23, 2022
@warango4 warango4 deleted the issue183 branch July 14, 2022 13:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

workload get is recommended twice in create/update/apply if workload fails to become ready under wait flag

5 participants