Skip to content
This repository was archived by the owner on May 18, 2026. It is now read-only.

Added delivery on get output#258

Merged
shashwathi merged 2 commits into
vmware-tanzu:mainfrom
odinnordico:issue-251-show-deliverable
Aug 11, 2022
Merged

Added delivery on get output#258
shashwathi merged 2 commits into
vmware-tanzu:mainfrom
odinnordico:issue-251-show-deliverable

Conversation

@odinnordico
Copy link
Copy Markdown
Contributor

Pull request

What this PR does / why we need it

  • Adds Delivery section to get output
    • Adds the Delivery Name
    • Adds the Deliverable resources with status information
  • Removes last update and ready from Supply Chain section
  • Merge workload and delivery messages

Which issue(s) this PR fixes

Fixes #251

Describe testing done for PR

Create different workloads in a TAP1.2 cluster and run get command from apps plugin

Additional information or special notes for your reviewer

image

image

Signed-off-by: Diego Alfonso <dalfonso@vmware.com>
Comment thread pkg/commands/workload_get.go Outdated
Comment thread pkg/apis/cartographer/v1alpha1/deliverable.go
Comment thread pkg/commands/workload_get.go
Copy link
Copy Markdown
Contributor

@shashwathi shashwathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

  • there is lot of repeated code for creating dies obj for deliverable conditions and other parts of the Deliverable object. Revisit that logic and see if you can create func in Die package or declare those variable outside of test to be reused.

Comment thread pkg/commands/workload_get.go Outdated
Signed-off-by: Diego Alfonso <dalfonso@vmware.com>
@odinnordico odinnordico requested a review from shashwathi August 11, 2022 16:17
@shashwathi shashwathi merged commit 0c2bca3 into vmware-tanzu:main Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

workload get includes deliverable information when available

3 participants