This repository was archived by the owner on May 18, 2026. It is now read-only.
Added delivery on get output#258
Merged
shashwathi merged 2 commits intoAug 11, 2022
Merged
Conversation
Signed-off-by: Diego Alfonso <dalfonso@vmware.com>
shashwathi
reviewed
Aug 10, 2022
shashwathi
reviewed
Aug 10, 2022
shashwathi
reviewed
Aug 10, 2022
Contributor
shashwathi
left a comment
There was a problem hiding this comment.
looks good
- there is lot of repeated code for creating dies obj for deliverable conditions and other parts of the Deliverable object. Revisit that logic and see if you can create func in Die package or declare those variable outside of test to be reused.
Signed-off-by: Diego Alfonso <dalfonso@vmware.com>
shashwathi
approved these changes
Aug 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
What this PR does / why we need it
Which issue(s) this PR fixes
Fixes #251
Describe testing done for PR
Create different workloads in a TAP1.2 cluster and run get command from apps plugin
Additional information or special notes for your reviewer