This repository was archived by the owner on May 18, 2026. It is now read-only.
Allow pass maven artifact through flags #256 #259
Merged
Merged
Conversation
c49ec51 to
e4ad3b3
Compare
odinnordico
reviewed
Aug 11, 2022
Contributor
Author
|
/rebase |
Signed-off-by: Wendy Arango <warango@vmware.com>
- add unit tests - update validation for source check to include maven param - add e2e test for maven Signed-off-by: Shash Reddy <snagarajared@vmware.com>
e4ad3b3 to
beb0f72
Compare
odinnordico
approved these changes
Aug 17, 2022
Contributor
shaheerkootteeri
left a comment
There was a problem hiding this comment.
A clarification in the code
Contributor
AC
LGTM overall!Note: if all the required maven flags are provided and |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Allows passing maven info through flags.
paramsyamlparamsyamlsince it's going to delete the ones that are not updatedWhich issue(s) this PR fixes
Fixes #170