Skip to content
This repository was archived by the owner on May 18, 2026. It is now read-only.

fix: hide ready message when empty#264

Merged
shashwathi merged 1 commit into
vmware-tanzu:mainfrom
odinnordico:issue-251-empty-messages
Aug 16, 2022
Merged

fix: hide ready message when empty#264
shashwathi merged 1 commit into
vmware-tanzu:mainfrom
odinnordico:issue-251-empty-messages

Conversation

@odinnordico
Copy link
Copy Markdown
Contributor

Pull request

What this PR does / why we need it

Prevent messages to be printed when the actual condition message is empty

Which issue(s) this PR fixes

Fixes #251

Describe testing done for PR

Additional information or special notes for your reviewer

@odinnordico odinnordico changed the title chore: fixed hide ready message when empty fix: hide ready message when empty Aug 16, 2022
@odinnordico odinnordico force-pushed the issue-251-empty-messages branch from fce373a to 8b7d136 Compare August 16, 2022 15:53
Comment thread pkg/printer/workload_deliverable_printer.go Outdated
Comment thread pkg/printer/workload_status_printer.go Outdated
@odinnordico odinnordico marked this pull request as draft August 16, 2022 16:23
@odinnordico odinnordico force-pushed the issue-251-empty-messages branch from 8b7d136 to e552b1d Compare August 16, 2022 16:54
@odinnordico odinnordico marked this pull request as ready for review August 16, 2022 16:55
@odinnordico odinnordico requested a review from shashwathi August 16, 2022 16:56
Signed-off-by: Diego Alfonso <dalfonso@vmware.com>
@odinnordico odinnordico force-pushed the issue-251-empty-messages branch from e552b1d to c740893 Compare August 16, 2022 22:00
@shashwathi shashwathi merged commit d7e1442 into vmware-tanzu:main Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

workload get includes deliverable information when available

3 participants