Skip to content
This repository was archived by the owner on May 18, 2026. It is now read-only.

Remove dependency from CLI code base in e2e test framework#267

Merged
shashwathi merged 3 commits into
vmware-tanzu:mainfrom
shashwathi:ci-framework
Aug 18, 2022
Merged

Remove dependency from CLI code base in e2e test framework#267
shashwathi merged 3 commits into
vmware-tanzu:mainfrom
shashwathi:ci-framework

Conversation

@shashwathi
Copy link
Copy Markdown
Contributor

Fixes #265

Signed-off-by: Shash Reddy <snagarajared@vmware.com>
Signed-off-by: Shash Reddy <snagarajared@vmware.com>
@shashwathi shashwathi marked this pull request as ready for review August 17, 2022 19:51
Copy link
Copy Markdown
Member

@rashedkvm rashedkvm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@odinnordico odinnordico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGreatTM

- this will help us debug if we encounter any errors in e2e tests
- continue to run the tests even if one of them fails
- use assert lib to simplify error checks

Signed-off-by: Shash Reddy <snagarajared@vmware.com>
@shashwathi shashwathi merged commit a0b57e3 into vmware-tanzu:main Aug 18, 2022
@shashwathi shashwathi deleted the ci-framework branch August 18, 2022 01:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove dependency for e2e test framework from apps plugin CLI codebase

4 participants